[Pdbg] [PATCH 3/3] cfam: Remove relax delay

Joel Stanley joel at jms.id.au
Tue May 22 16:06:28 AEST 2018


From: Benjamin Herrenschmidt <benh at kernel.crashing.org>

I can't find use for it, I suspect it worked around bugs
elsewhere. At least on P9 things work fine without it
and much faster too.

Signed-off-by: Benjamin Herrenschmidt <benh at kernel.crashing.org>
Signed-off-by: Joel Stanley <joel at jms.id.au>
---
 libpdbg/cfam.c | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/libpdbg/cfam.c b/libpdbg/cfam.c
index ec79d755cb91..dd01d7409801 100644
--- a/libpdbg/cfam.c
+++ b/libpdbg/cfam.c
@@ -35,12 +35,6 @@
 #define FSI_SET_PIB_RESET_REG 0x7
 #define  FSI_SET_PIB_RESET PPC_BIT32(0)
 
-/* For some reason the FSI2PIB engine dies with frequent
- * access. Letting it have a bit of a rest seems to stop the
- * problem. This sets the number of usecs to sleep between SCOM
- * accesses. */
-#define FSI2PIB_RELAX	50
-
 /*
  * Bridge registers on XSCOM that allow generatoin
  * of OPB cycles
@@ -82,8 +76,6 @@ static int fsi2pib_getscom(struct pib *pib, uint64_t addr, uint64_t *value)
 {
 	uint32_t result;
 
-	usleep(FSI2PIB_RELAX);
-
 	/* Get scom works by putting the address in FSI_CMD_REG and
 	 * reading the result from FST_DATA[01]_REG. */
 	CHECK_ERR(fsi_write(&pib->target, FSI_CMD_REG, addr));
@@ -97,8 +89,6 @@ static int fsi2pib_getscom(struct pib *pib, uint64_t addr, uint64_t *value)
 
 static int fsi2pib_putscom(struct pib *pib, uint64_t addr, uint64_t value)
 {
-	usleep(FSI2PIB_RELAX);
-
 	CHECK_ERR(fsi_write(&pib->target, FSI_DATA0_REG, (value >> 32) & 0xffffffff));
 	CHECK_ERR(fsi_write(&pib->target, FSI_DATA1_REG, value & 0xffffffff));
 	CHECK_ERR(fsi_write(&pib->target, FSI_CMD_REG, FSI_CMD_REG_WRITE | addr));
-- 
2.17.0



More information about the Pdbg mailing list