[Pdbg] [PATCH v2 1/3] p9-pib.dtsi.m4: Fix chiplet generation

Alistair Popple alistair at popple.id.au
Fri May 18 11:34:29 AEST 2018


Thanks Balbir, I have a couple of questions/comments though:

1. Why do we need to remove the other chiplets? They represent things like for
   example the Nest.

2. For the cores I don't think we want to change the index property for the core
   (as that is used internally to map eg. -c0 to the correct core). I think what
   we should probably do is use the first argument of CORE(X, Y) as the core
   index and the second for the chiplet number.

Regards,

Alistair

On Friday, 11 May 2018 3:43:05 PM AEST Balbir Singh wrote:
> Make the numbers correspond to the pervasive numbers.
> This will be used in the future for checkstop analysis.
> Also remove wild chiplets, more tamed ones will be
> added in the next set of patches
> 
> Signed-off-by: Balbir Singh <bsingharora at gmail.com>
> ---
>  p9-pib.dts.m4 | 68 +++++++++++++++++++++--------------------------------------
>  1 file changed, 24 insertions(+), 44 deletions(-)
> 
> diff --git a/p9-pib.dts.m4 b/p9-pib.dts.m4
> index e0248d1..1c8136e 100644
> --- a/p9-pib.dts.m4
> +++ b/p9-pib.dts.m4
> @@ -53,47 +53,27 @@ htm at 50128C0 {
>  	index = <0x1>;
>  };
>  
> -CORE(0, 0);
> -CORE(1, 1);
> -CORE(2, 2);
> -CORE(3, 3);
> -CORE(4, 4);
> -CORE(5, 5);
> -CORE(6, 6);
> -CORE(7, 7);
> -CORE(8, 8);
> -CORE(9, 9);
> -CORE(10, 10);
> -CORE(11, 11);
> -CORE(12, 12);
> -CORE(13, 13);
> -CORE(14, 14);
> -CORE(15, 15);
> -CORE(16, 16);
> -CORE(17, 17);
> -CORE(18, 18);
> -CORE(19, 19);
> -CORE(20, 20);
> -CORE(21, 21);
> -CORE(22, 22);
> -CORE(23, 23);
> -
> -CHIPLET(1);
> -CHIPLET(2);
> -CHIPLET(3);
> -CHIPLET(4);
> -CHIPLET(5);
> -CHIPLET(6);
> -CHIPLET(7);
> -CHIPLET(8);
> -CHIPLET(9);
> -CHIPLET(12);
> -CHIPLET(13);
> -CHIPLET(14);
> -CHIPLET(15);
> -CHIPLET(16);
> -CHIPLET(17);
> -CHIPLET(18);
> -CHIPLET(19);
> -CHIPLET(20);
> -CHIPLET(21);
> +CORE(0, 32);
> +CORE(1, 33);
> +CORE(2, 34);
> +CORE(3, 35);
> +CORE(4, 36);
> +CORE(5, 37);
> +CORE(6, 38);
> +CORE(7, 39);
> +CORE(8, 40);
> +CORE(9, 41);
> +CORE(10, 42);
> +CORE(11, 43);
> +CORE(12, 44);
> +CORE(13, 45);
> +CORE(14, 46);
> +CORE(15, 47);
> +CORE(16, 48);
> +CORE(17, 49);
> +CORE(18, 50);
> +CORE(19, 51);
> +CORE(20, 52);
> +CORE(21, 53);
> +CORE(22, 54);
> +CORE(23, 55);
> 




More information about the Pdbg mailing list