[Pdbg] [PATCH] libpdbg: progress bars!

[Alistair Popple]

On Friday, 11 May 2018 4:29:19 PM AEST Joel Stanley wrote:
> On 11 May 2018 at 16:23, Amitay Isaacs <amitay at ozlabs.org> wrote:
> > On Thu, 2018-05-10 at 16:58 +0930, Joel Stanley wrote:
> >>  $ pdbg -p 0 getmem 0x8040278 100 > /tmp/log
> >>  [==================================================] 100%
> >>
> >> Signed-off-by: Joel Stanley <joel at jms.id.au>
> >
> > This probably belongs to the pdbg tool and not the library.  In that
> > case we may need a polling interface to library functions to find out
> > the progress. :-(
> >
> > Or, we can register callbacks for progress_tick from pdbg tool and emit
> > progress_tick from various long operations in the library.
> 
> Yeah. I did a v2 of this that makes it optional, as there are plenty
> of cases where we don't want progress bars.
> 
> It is super useful for big transfers though. I recommend doing a getmem
> with this patch applied; if it's a multi-minute transfer it will
> predict how long it takes.

I guess I can take that for now as it seems to be useful and the v2 didn't look
too invasive, but really I agree with Amitay here - we need some more general
way of doing this kind of stuff from the library which typically leaves output
formatting to the application.

Amitay I can't remember were you looking into some improvements to the way we do
logging?

Regards,

Alistair

> Cheers,
> 
> Joel
>