[Pdbg] [PATCH 1/2] libpdbg: Check if scom controllers are exposed

Rashmica Gupta rashmica.g at gmail.com
Tue May 8 10:14:52 AEST 2018


There is no 2/2 patch - I formatted the patch wrong...

On Tue, May 8, 2018 at 10:11 AM, Rashmica Gupta <rashmica.g at gmail.com>
wrote:

> If CONFIG_SCOM_DEBUGFS is not set in the running kernel then
> the scom controllers are not exposed and so using getscom
> won't work. Add check for /sys/kernel/debug/powerpc/scom to
> give a more useful error message.
>
> Signed-off-by: Rashmica Gupta <rashmica.g at gmail.com>
> ---
>  libpdbg/host.c | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/libpdbg/host.c b/libpdbg/host.c
> index f43b355..cf71e5c 100644
> --- a/libpdbg/host.c
> +++ b/libpdbg/host.c
> @@ -95,6 +95,13 @@ static int host_pib_probe(struct pdbg_target *target)
>         if (chip_id == -1)
>                 goto out;
>
> +       /* This check should probably be done earlier */
> +       if (access(XSCOM_BASE_PATH, F_OK) == -1)
> +       {
> +               fprintf(stderr, "Can not access %s. ", XSCOM_BASE_PATH);
> +               fprintf(stderr, "Is CONFIG_SCOM_DEBUGFS set?\n");
> +       }
> +
>         if (asprintf(&access_fn, "%s/%08d/access", XSCOM_BASE_PATH,
> chip_id) < 0)
>                 goto out;
>
> --
> 2.14.3
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ozlabs.org/pipermail/pdbg/attachments/20180508/36b4d709/attachment.html>


More information about the Pdbg mailing list