[Pdbg] [PATCH 7/7] pdbg/htm: Enforce powersave=off

Cyril Bur cyrilbur at gmail.com
Fri Mar 16 14:10:14 AEDT 2018


On Fri, 2018-03-16 at 13:42 +1100, Alistair Popple wrote:
> > +		i = 0;
> > +		pdbg_for_each_class_target("core", target)
> > +			if (!target_is_disabled(target))
> > +				i++;
> > +		if (i == 0)
> > +			fprintf(stderr, "You haven't selected any HTM Cores\n");
> > +		if (i > 1) {
> > +			fprintf(stderr, "It doesn't make sense to core trace on"
> > +				" multiple cores at once. %d\n", i);
> 
> For my own background why not? Does the HW not support it? Or do we just not
> support it here because it's "hard"?

Depends on your definition of hard. I don't believe there is a hardware
limitation (which makes me think that the printf is misleading, will
fix) - although I've never actually tried.

The reason I don't want to allow it for now is that doing so would
require partitioning up the memtrace buffer provided by the kernel and
remembering how it has been split up across multiple calls. I've not
seen anyone require such functionality and I don't think any of our
current tooling can do it either.

> 
> > +			fprintf(stderr, "What you probably want is -p 0 -c x\n");
> > +		}
> > +		if (i != 1)
> > +			return 0;
> > +	}
> > +
> >  	optind++;
> >  	for (i = 0; i < ARRAY_SIZE(actions); i++) {
> >  		if (strcmp(argv[optind], actions[i].name) == 0) {
> > 
> 
> 


More information about the Pdbg mailing list