[Pdbg] [PATCH v2 2/2] main: Address by linux CPU number with PPC host backend

[Michael Neuling]

On Tue, 2018-07-17 at 13:48 +1000, Alistair Popple wrote:
> > > Can we also rename MAX_CHIPS to MAX_CORES?
> > 
> > We definily should.  However...
> > 
> > There is horrible overloading of chiplet array to address chiplets.
> > 
> > 			/* This is kinda broken as we're overloading what '-c'
> > 			 * means - it's now up to each command to select targets
> > 			 * based on core/chiplet. We really need a better
> > 			 * solution to target selection. */
> > 			pdbg_for_each_target("chiplet", pib, chip) {
> > 
> > We need to figure out a way to target any "chiplet" rather than adding letters of alphabet for each type of chiplet.
> 
> Agreed. I guess that's what your interactive path selection patches are going to
> provide.

Ok I'll let you guys fix that :-)

I'll repost with the 'int l_list[MAX_PROCESSORS * MAX_THREADS * MAX_CHIPS]' fix
in v3.

> > Maybe use -p/-c/-t or -l for main targets (processor/chip/thread) and create a different scheme for other chiplets?
> 
> Sounds good to me. I think we can drop the horrid overloading, I doubt anyone is
> using it. It crept in there mostly for testing purposes.

+1 

Mikey