[Pdbg] [PATCH 3/6] htm: Use splice() to copy dump

Alistair Popple alistair at popple.id.au
Thu Jul 12 13:52:35 AEST 2018


Out of interest I hacked up a test using sendfile. Results on my laptop were
about the same as using the splice method from this patch. Arguably using
sendfile is cleaner as you don't need the pipe but this patch is perfectly
readable so I've merged it for now. Thanks Mikey.

- Alistair

On Thursday, 5 July 2018 5:48:12 PM AEST Michael Neuling wrote:
> On Wed, 2018-07-04 at 14:18 +1000, Amitay Isaacs wrote:
> > On Tue, 2018-07-03 at 16:58 +1000, Michael Neuling wrote:
> > > Gives 10% speedup for no more complexity.
> > 
> > How about copy_file_range()?
> 
> Nice but it doesn't work since the FDs are on different filesystems (debugfs vs
> real disk)
> 
> The man page confirms this:
> 
> ERRORS:
> ....
>        EXDEV  The files referred to by file_in and file_out  are  not  on  the
>   
>            same mounted filesystem.
> 
> Mikey
> 




More information about the Pdbg mailing list