[Pdbg] [PATCH 1/2] Add checkstop FIR support via DTS

[Alistair Popple]

Hi Balbir,

> +mc {
> +	fir_mask=<0x1800000 0x0>;
> +	instances=<0x0 0x1>;
> +	compatible="ibm,chiplet-fir";
> +};

There are plans to add each chiplet as it's own node in the device-tree with an
associated ibm,chiplet-id = <0x??> to idenitfy it. Rather than having to have a
seperate chiplet representation for a chiplets top-level FIR register I think it
makes more sense to link the bits set in global_fir with device tree nodes based
on the chiplet-id property. So for example the above would become:

eg:

mc01 {
     reg = <0xc0ffee>;
     ibm,chiplet-id = <0x7>;
};

mc23 {
    reg = <0xdeadbeef>;
    ibm,chiplet-id = <0x8>;
};

Admittedly this results in each chiplet having to explicitly exist in the
device-tree, but that will be required anyway for the "reg = <...>" properties.
Anyway let me know your thoughts.

- Alistair

> +
> +ob {
> +	fir_mask=<0x780000 0x0>;
> +	instances=<0x0 0x3>;
> +	compatible="ibm,chiplet-fir";
> +};
> +
> +pci0 {
> +	fir_mask=<0x40000 0x0>;
> +	instances=<0x0 0x0>;
> +	compatible="ibm,chiplet-fir";
> +};
> +
> +pci1 {
> +	fir_mask=<0x20000 0x0>;
> +	instances=<0x1 0x1>;
> +	compatible="ibm,chiplet-fir";
> +};
> +
> +pci2 {
> +	fir_mask=<0x10000 0x0>;
> +	instances=<0x2 0x2>;
> +	compatible="ibm,chiplet-fir";
> +};
> +
> +eq {
> +	fir_mask=<0xfc00 0x0>;
> +	instances=<0x0 0x5>;
> +	compatible="ibm,chiplet-fir";
> +};
> +
> +ec {
> +	fir_mask=<0x0 0xffffff00>;
> +	instances=<0x0 0x17>;
> +	compatible="ibm,chiplet-fir";
> +};
> +
> diff --git a/p9-fsi.dtsi.m4 b/p9-fsi.dtsi.m4
> index fde71e4..bea7b9f 100644
> --- a/p9-fsi.dtsi.m4
> +++ b/p9-fsi.dtsi.m4
> @@ -32,6 +32,7 @@
>  				include(p9-pib.dts.m4)dnl
>  			};
>  		};
> +		include(p9-fir.dtsi.m4)
>  
>  	};
>  };
> diff --git a/p9-host.dts.m4 b/p9-host.dts.m4
> index 5566acd..31ebed2 100644
> --- a/p9-host.dts.m4
> +++ b/p9-host.dts.m4
> @@ -18,4 +18,5 @@
>  	      index = <0x1>;
>  	      include(p9-pib.dts.m4)dnl
>  	};
> +	include(p9-fir.dtsi.m4)
>  };
> diff --git a/p9-kernel.dts.m4 b/p9-kernel.dts.m4
> index ff19779..b30eaa9 100644
> --- a/p9-kernel.dts.m4
> +++ b/p9-kernel.dts.m4
> @@ -33,5 +33,6 @@
>  				 include(p9-pib.dts.m4)dnl
>  			};
>  		};
> +		include(p9-fir.dtsi.m4)
>  	};
>  };
>