[Pdbg] [PATCH v2 00/10] Convert more commands to path based targeting
Alistair Popple
alistair at popple.id.au
Mon Dec 3 14:56:20 AEDT 2018
Thanks Amitay, merged. I particularly like patch 7 ;-)
- Alistair
On Friday, 23 November 2018 3:40:09 PM AEDT Amitay Isaacs wrote:
> Hi,
>
> Here are the patches to conver the remaining pdbg commands (except
> getmem/putmem) to path based targeting. There are two kinds of commands.
>
> 1. Following commands operate on a single class
>
> start, stop, step, sreset, threadstatus - thread
> getring - chiplet
>
> 2. Followings commands require multiple classes
>
> regs - thread & adu
> htm core - core & adu
> gdbserver - thread & adu
>
> For these commands the target specification is done for the primary target
> classes. Since most of these commands require adu for memory access,
> we find the first adu target that's available and use that adu target.
>
> v2 change:
> - Fix -l option handling
> - Improve target selection code for htm
> - Check that valid target is selected for gdbserver
>
>
> Amitay Isaacs (10):
> main: Move device_node setting before parse_options
> main: Mark print_target static
> main: Convert getring to path based targeting
> main: Convert thread commands start/stop/step/sreset
> main: Convert threadstatus command to path based targeting
> main: Convert regs command to path based targeting
> main: Drop unused iterators with callbacks
> main: Convert htm commands to path based targeting
> main: Convert gdbserver command to path based targeting
> main: Drop unused target_select/target_selected functions
>
> src/htm.c | 106 ++++++++++-------
> src/main.c | 84 ++------------
> src/main.h | 12 --
> src/pdbgproxy.c | 77 ++++++------
> src/ring.c | 56 ++++++---
> src/thread.c | 303 ++++++++++++++++++++++++++----------------------
> 6 files changed, 309 insertions(+), 329 deletions(-)
More information about the Pdbg
mailing list