[Pdbg] [PATCH 3/4] libpdbg: Drop pdbg_target_chip_id()

Amitay Isaacs amitay at ozlabs.org
Mon Dec 3 14:27:57 AEDT 2018


Signed-off-by: Amitay Isaacs <amitay at ozlabs.org>
---
 libpdbg/libpdbg.c | 15 ---------------
 libpdbg/libpdbg.h |  4 ----
 2 files changed, 19 deletions(-)

diff --git a/libpdbg/libpdbg.c b/libpdbg/libpdbg.c
index f3ed959..0e71dec 100644
--- a/libpdbg/libpdbg.c
+++ b/libpdbg/libpdbg.c
@@ -168,21 +168,6 @@ int pdbg_target_u32_index(struct pdbg_target *target, const char *name, int inde
         return 0;
 }
 
-uint32_t pdbg_target_chip_id(struct pdbg_target *target)
-{
-        uint32_t id;
-
-	while (pdbg_target_u32_property(target, "chip-id", &id)) {
-		target = target->parent;
-
-		/* If we hit this we've reached the top of the tree
-		 * and haven't found chip-id */
-		assert(target);
-	}
-
-	return id;
-}
-
 void pdbg_progress_tick(uint64_t cur, uint64_t end)
 {
 	if (progress_tick)
diff --git a/libpdbg/libpdbg.h b/libpdbg/libpdbg.h
index 44540e4..301c2c8 100644
--- a/libpdbg/libpdbg.h
+++ b/libpdbg/libpdbg.h
@@ -94,10 +94,6 @@ uint64_t pdbg_target_address(struct pdbg_target *target, uint64_t *size);
 #define pdbg_get_address(target, index, size) \
 	(index == 0 ? pdbg_target_address(target, size) : assert(0))
 
-/* Find an chip-id property in this node; if not found, walk up the parent
- * nodes. Returns -1 if no chip-id property exists. */
-uint32_t pdbg_target_chip_id(struct pdbg_target *target);
-
 /* Misc. */
 void pdbg_targets_init(void *fdt);
 void pdbg_target_probe_all(struct pdbg_target *parent);
-- 
2.19.2



More information about the Pdbg mailing list