[Pdbg] [PATCH 03/19] libpdbg: Add in getxer and putxer functions

[Nicholas Piggin]

This is all pretty awesome, I'm having a look over it...

On Wed, 29 Aug 2018 11:50:31 +1000
Rashmica Gupta <rashmica.g at gmail.com> wrote:


> diff --git a/libpdbg/target.h b/libpdbg/target.h
> index 9f055ac..8bad405 100644
> --- a/libpdbg/target.h
> +++ b/libpdbg/target.h
> @@ -153,6 +153,8 @@ struct thread {
>  	int (*ram_setup)(struct thread *);
>  	int (*ram_instruction)(struct thread *, uint64_t opcode, uint64_t *scratch);
>  	int (*ram_destroy)(struct thread *);
> +	int (*ram_getxer)(struct pdbg_target *, uint64_t *value);
> +	int (*ram_putxer)(struct pdbg_target *, uint64_t value);
>  };
>  #define target_to_thread(x) container_of(x, struct thread, target)

I would say we might want to end up having a ram_spr function
that each target can use to filter things out or do their magic
overrides. MSR and NIA and other fake SPRs can be included too.
This is fine for now though.

pdbg doesn't have a big development process, but as a general
comment I like putting bug fixes (and you've made quite a few)
and cleanups at the start of a series.

Thanks,
Nick