[Pdbg] [PATCH 3/5] Makefile: Do not install test programs

[Amitay Isaacs]

On Thu, 2018-08-02 at 15:03 +1000, Alistair Popple wrote:
> Testing is something that I would like to start focussing on. This
> test was
> added in this way as a stop gap so it didn't get lost/bitrot but I am
> open to
> ideas for how we could do this kind of testing better.

It's fine to add tests.  Question is whether we want to installthe test
binaries?  Adding them to noinst_PROGRAMS allows the tests to be built
so they can be tested in tree. May be we need to add a "check" target.

Now that I have got my head around jenkins, how about setting up
jenkins job to build pdbg on platforms of interest (arm, ppc64le,
x86_64) and run tests (well one test for now, more later!)

Amitay.

> 
> - Alistair
> 
> On Monday, 16 July 2018 4:32:14 PM AEST Amitay Isaacs wrote:
> > Signed-off-by: Amitay Isaacs <amitay at ozlabs.org>
> > ---
> >  Makefile.am | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/Makefile.am b/Makefile.am
> > index 7206fc2..739ab23 100644
> > --- a/Makefile.am
> > +++ b/Makefile.am
> > @@ -3,7 +3,8 @@ AM_MAKEFLAGS = --no-print-directory
> >  
> >  GIT_SHA1 ?= `git --work-tree=$(top_srcdir) --git-
> > dir=$(top_srcdir)/.git describe --always --long --dirty 2>/dev/null
> > || echo unknown`
> >  
> > -bin_PROGRAMS = pdbg optcmd_test
> > +bin_PROGRAMS = pdbg
> > +noinst_PROGRAMS = optcmd_test
> >  
> >  ACLOCAL_AMFLAGS = -Im4
> >  AM_CFLAGS = -I$(top_srcdir)/ccan/array_size -Wall -Werror -O2
> > 
> 
> 

Amitay.
-- 

Behind every successful man stands a proud wife and surprised mother-in-law.
- Brooks Hays