[Pdbg] [PATCH 02/14] libpdbg/p9chip.c: remove sreset SRR1 workaround

Nicholas Piggin npiggin at gmail.com
Mon Apr 9 17:35:10 AEST 2018


sreset is fixed in DD2 and above, and with recent kernels. pdbg sreset
will crash the host with this workaround in place, so remove it.

Signed-off-by: Nicholas Piggin <npiggin at gmail.com>
---
 libpdbg/p9chip.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/libpdbg/p9chip.c b/libpdbg/p9chip.c
index 9fb5e1d..033e3eb 100644
--- a/libpdbg/p9chip.c
+++ b/libpdbg/p9chip.c
@@ -114,11 +114,6 @@ static int p9_thread_sreset(struct thread *thread)
 	if (p9_get_thread_status(thread) != (THREAD_STATUS_QUIESCE | THREAD_STATUS_ACTIVE))
 		return 1;
 
-	/* This will force SRR1[46:47] == 0b00 which means the kernel should
-	 * enter xmon. However it will hide the fact we may have come from a
-	 * powersave state in which register contents were lost. We need a
-	 * kernel side fix for that. */
-	thread_write(thread, P9_DIRECT_CONTROL, PPC_BIT(32 + 8*thread->id));
 	thread_write(thread, P9_DIRECT_CONTROL, PPC_BIT(4 + 8*thread->id));
 
 	return 0;
-- 
2.17.0



More information about the Pdbg mailing list