[PATCH v2 0/7] Add support for series dependencies

[Stephen Finucane]

On Fri, 2024-11-01 at 11:09 -0400, Adam Hassick wrote:
> Stephen,
> 
> Thank you for the review. I'll address the comments on the parser patch and submit a v3 within the next 2 weeks. My time to work on this is a bit limited as well.

Sounds good. No panic.

> For the front-end representation of the dependencies, I want to represent these relations on a series detail view, which doesn't exist yet. Maybe, once the patches for the series detail view are merged, I can to add that as well.

Fair. fwiw, there is an in-flight series to add this:

https://github.com/getpatchwork/patchwork/pull/589

However, as Hero notes there, it won't be massively useful as-is right now due
to a lack of a series state field. Still, at least we've a path forward for this
later.

Cheers,
Stephen

> 
> Regards,
> Adam
> 
> On Thu, Oct 31, 2024 at 6:45 PM Stephen Finucane <stephen at that.guru> wrote:
> > On Thu, 2024-08-29 at 10:54 -0400, Adam Hassick wrote:
> > > Stephen,
> > > 
> > > Is there anything I need to do before this patch can be reviewed? It
> > > has been a while, I just want to make sure that I am not blocking this
> > > in any way.
> > 
> > Apologies for the delay on this but my time is limited recently :(
> > 
> > I think I've reviewed everything. The only comments I had were on the parser
> > changes. In addition, I don't see any changes for the web UI here. Have you any
> > plans for exposing it through said interface?
> > 
> > I'll test this (or, better, try to delegate testing to someone) from a
> > performance perspective over the weekend but I see the joins there and imagine
> > things are fine.
> > 
> > Nice work, again.
> > 
> > Stephen
> > 
> > > On Tue, Jul 30, 2024 at 5:04 PM Adam Hassick <ahassick at iol.unh.edu> wrote:
> > > > 
> > > > This patch series adds support for series dependencies. A series dependency
> > > > may be declared by another series when that series alone will not apply,
> > > > compile, or otherwise function properly without the dependent series.
> > > > 
> > > > Including the "Depends-on" tag in any patch commit message or in the cover
> > > > letter blurb will signal Patchwork to add the referenced series as a
> > > > dependency. The value for this tag may be a message ID of the dependent
> > > > series cover letter or any patch in the dependent series. Or, alternatively,
> > > > it may be the web URL of the dependent series or any patch in that series.
> > > > 
> > > > v2:
> > > > * Use message IDs instead of object IDs.
> > > > * Check for invalid dependencies before adding them.
> > > > 
> > > > Adam Hassick (7):
> > > >    models: Add field for series dependencies
> > > >    api: Add fields to series detail view
> > > >    parser: Parse "Depends-on" tags in emails
> > > >    tests: Add tests for new functionality
> > > >    docs: Increment API version
> > > >    docs: Add generated API schemas
> > > >    release-notes: Add release note
> > > > 
> > > >   docs/api/rest/index.rst                       |   42 +-
> > > >   docs/api/rest/schemas/v1.3.rst                |    4 +-
> > > >   docs/api/rest/schemas/v1.4.rst                |    5 +
> > > >   docs/api/schemas/generate-schemas.py          |    4 +-
> > > >   docs/api/schemas/latest/patchwork.yaml        |   18 +-
> > > >   docs/api/schemas/patchwork.j2                 |   18 +
> > > >   docs/api/schemas/v1.4/patchwork.yaml          | 3242 +++++++++++++++++
> > > >   docs/usage/overview.rst                       |   11 +
> > > >   patchwork/api/series.py                       |   26 +-
> > > >   .../migrations/0047_series_dependencies.py    |   23 +
> > > >   patchwork/models.py                           |   26 +
> > > >   patchwork/parser.py                           |   90 +-
> > > >   patchwork/tests/api/test_series.py            |   33 +-
> > > >   .../tests/series/dependency-base-patch.mbox   |  102 +
> > > >   .../series/dependency-multi-2.mbox.template   |  110 +
> > > >   .../series/dependency-multi.mbox.template     |  109 +
> > > >   .../series/dependency-one-cover.mbox.template |  128 +
> > > >   .../dependency-one-first-patch.mbox.template  |  125 +
> > > >   patchwork/tests/test_parser.py                |   52 +
> > > >   patchwork/tests/test_series.py                |  271 ++
> > > >   patchwork/urls.py                             |   10 +-
> > > >   ...-series-dependencies-6696458586e795c7.yaml |   18 +
> > > >   22 files changed, 4435 insertions(+), 32 deletions(-)
> > > >   create mode 100644 docs/api/rest/schemas/v1.4.rst
> > > >   create mode 100644 docs/api/schemas/v1.4/patchwork.yaml
> > > >   create mode 100644 patchwork/migrations/0047_series_dependencies.py
> > > >   create mode 100644 patchwork/tests/series/dependency-base-patch.mbox
> > > >   create mode 100644 patchwork/tests/series/dependency-multi-2.mbox.template
> > > >   create mode 100644 patchwork/tests/series/dependency-multi.mbox.template
> > > >   create mode 100644 patchwork/tests/series/dependency-one-cover.mbox.template
> > > >   create mode 100644 patchwork/tests/series/dependency-one-first-patch.mbox.template
> > > >   create mode 100644 releasenotes/notes/add-series-dependencies-6696458586e795c7.yaml
> > > > 
> > > > --
> > > > 2.45.2
> > > > 
> >