[PATCH v4 5/5] patch-list: add inline dropdown for delegate and state one-off changes

Stephen Finucane stephen at that.guru
Sat Nov 2 03:03:02 AEDT 2024


On Mon, 2021-08-23 at 18:28 +0000, Raxel Gutierrez wrote:
> Add dropdown for the cell values of the Delegate and State columns for
> each individual patch to make one-off changes to patches. The dropdowns
> are only viewable if the user has patch edit permissions.
> 
> Change the generic_list method to pass the list of states and
> maintainers to the patch list view context to populate the dropdown
> options. The static patch-list.js file now uses the modularity of the
> fetch request and update/error messages handling of rest.js.
> 
> TODO: The loading of the patch-list page is very slow now because it
> seems that for each call to check if a patch is editable by a user, the
> db is accessed. Changes in the backend need to be made so this is done
> with only done with only one call to the db.
> 
> Signed-off-by: Raxel Gutierrez <raxel at google.com>

I didn't apply this patch. I'm not overly keen on adding yet another column to
that already-huge table and would like to re-evaluate how we could do this. The
rest is merged now though.

Stephen


More information about the Patchwork mailing list