[PATCH] templates/submission: Fix alignment of commit message

Stephen Finucane stephen at that.guru
Fri Nov 1 09:07:34 AEDT 2024


On Wed, 2024-10-23 at 21:05 +0200, Thomas Monjalon wrote:
> Hello, this patch is fixing a bug.
> Can it be merged please?

Sorry, Thomas. Wanted to get 3.2.0 out the door as-is just to free up the
pipeline so Hero and I can work through the many reviews sitting and waiting.

Reviewed-by: Stephen Finucane <stephen at that.guru>

...and applied.

Stephen

> 16/08/2024 19:02, Robin Jarry:
> > Thomas Monjalon, Aug 16, 2024 at 09:26:
> > > Preformatted content must not be indented
> > > because any space is kept in the output,
> > > making the content wrongly indented.
> > > 
> > > When aligning message headers to the left,
> > > the new HTML code has been indented
> > > including some preformatted content indented with two spaces.
> > > 
> > > The fix is to remove the indent of the content.
> > > 
> > > Fixes: fe34ab2ffad3 ("patch-detail: left align message headers")
> > 
> > This should be grouped with your signed-off-by trailer without a blank 
> > line in between so that git-interpret-trailers(1) can parse it.
> > 
> > > 
> > > Signed-off-by: Thomas Monjalon <thomas at monjalon.net>
> > > ---
> > >  patchwork/templates/patchwork/submission.html | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/patchwork/templates/patchwork/submission.html b/patchwork/templates/patchwork/submission.html
> > > index 85e7be4b..e924934f 100644
> > > --- a/patchwork/templates/patchwork/submission.html
> > > +++ b/patchwork/templates/patchwork/submission.html
> > > @@ -262,7 +262,7 @@
> > >      <span class="message-date">{{ submission.date }} UTC</span>
> > >    </div>
> > >    <pre class="content">
> > > -  {{ submission|commentsyntax }}
> > > +{{ submission|commentsyntax }}
> > >    </pre>
> > >  </div>
> > >  
> > 
> > Hi Thomas, I had noticed this but thought it was a CSS issue.
> > 
> > Looks good to me!
> > 
> > Reviewed-by: Robin Jarry <robin at jarry.cc>
> 
> 
> 
> _______________________________________________
> Patchwork mailing list
> Patchwork at lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/patchwork



More information about the Patchwork mailing list