[PATCH v1 4/9] settings: Add flag disable "Depends-on" parsing

[Adam Hassick]

On Fri, Jul 12, 2024 at 12:05 PM Stephen Finucane <stephen at that.guru> wrote:
>
> On Mon, 2024-06-17 at 18:18 -0400, Adam Hassick wrote:
> > Some operators of Patchwork instances may not want to allow series
> > dependencies. By providing this setting, these operators may disable
> > this behavior on their instance.
> >
> > Signed-off-by: Adam Hassick <ahassick at iol.unh.edu>
>
> This is only one of three feature flags - ENABLE_XMLRPC_API and ENABLE_REST_API
> being the other two. We actually plan on dropping the latter of these at some
> point since we consider the REST API to be mature at this point, and the only
> reason it ever existed was on off-chance that we introduced a serious security
> or performance issue. I don't think we need to worry about either here so I'm
> wondering if we need that flag. Are there any operators that you're aware of
> that have strong feelings about the feature? If not, can we drop this flag and
> default to always parsing dependencies?
>
> Stephen

We were a bit concerned that kernel.org may not like this feature, but
we can remove this if we want to minimize the number of feature flags.

> > ---
> >  patchwork/settings/base.py | 3 +++
> >  patchwork/settings/dev.py  | 2 ++
> >  2 files changed, 5 insertions(+)
> >
> > diff --git a/patchwork/settings/base.py b/patchwork/settings/base.py
> > index dccab6c..8b05d57 100644
> > --- a/patchwork/settings/base.py
> > +++ b/patchwork/settings/base.py
> > @@ -263,6 +263,9 @@ ENABLE_XMLRPC = False
> >  # Set to True to enable the Patchwork REST API
> >  ENABLE_REST_API = True
> >
> > +# Set to True to enable parsing "Depends-on" tags.
> > +ENABLE_DEPENDS_ON_PARSING = False
> > +
> >  REST_RESULTS_PER_PAGE = 30
> >  MAX_REST_RESULTS_PER_PAGE = 250
> >
> > diff --git a/patchwork/settings/dev.py b/patchwork/settings/dev.py
> > index 75c4b34..3688b24 100644
> > --- a/patchwork/settings/dev.py
> > +++ b/patchwork/settings/dev.py
> > @@ -80,3 +80,5 @@ if dbbackup:
> >  ENABLE_XMLRPC = True
> >
> >  ENABLE_REST_API = True
> > +
> > +ENABLE_DEPENDS_ON_PARSING = True
>