[PATCH] docker: rebase on vicamo/pyenv

Stephen Finucane stephen at that.guru
Wed Feb 23 02:00:42 AEDT 2022


On Thu, 2021-12-23 at 12:16 +0800, You-Sheng Yang wrote:
> Stephen Finucane <stephen at that.guru> 於 2021年12月23日 週四 上午6:05寫道:
> > 
> > On Sun, 2021-12-12 at 14:17 +0800, You-Sheng Yang wrote:
> > > Rebuild pyenv environments can be time-consuming and irrelevant to this
> > > project. Use a prebuild image to save some time here.
> > > 
> > > Signed-off-by: You-Sheng Yang <vicamo at gmail.com>
> > 
> > This is a good idea. I've created a similar image at [1] which (I think) will do
> > the same thing, simply so we can quickly iterate on it if we need to in the
> > future. Let me know if you spot anything amiss. If not, I'll merge this (with
> > the different base image) next week.
> 
> I think that looks good to me.

Thanks for looking at this. I completely forgot about it /o\ I've applied this
now.

> For those `apt-cache search` lines, I was to cover some major
> Debian/Ubuntu releases. You might not need them.

Good point. I stripped those (and added a credit linking back to your project)

> Besides, while python3.10 is out and 3.11 is coming, I was personally
> trying to rewrite a bit to allow automatic builds of newly available
> python versions in my own repo. Add some build argument to the build
> stage of the Dockerfile allows you to test that. Taking a step
> further, split build stage as builder and build-all stages as I did in
> [1], then you have a handy image for manual testing. Pretty convenient
> for me.

Thanks for the tips. I'll take a look into doing this. We need to do some work
on our supported Python versions for Patchwork proper so align nicely.

Thanks again,
Stephen

> 
> [1]:https://github.com/vicamo/docker-pyenv/blob/5159e6c94d2f173f6bcc3759448ce5dea228ab08/Dockerfile-debian.template



More information about the Patchwork mailing list