[PATCH 4/4] tests: Tweak comment API tests

Stephen Finucane stephen at that.guru
Sat Sep 4 01:55:04 AEST 2021

On Thu, 2021-09-02 at 12:24 +1000, Daniel Axtens wrote:
> Not really something for this exact patch, but I do wonder as API
> versions proliferate if we should have infrastructure to test something
> on all supported API versions.
> [Perhaps it's my lack of a formal CS education showing here but I feel
> like there's probably some software design pattern for this, and I have
> a weird intuition that I'm describing a Factory, but the wikipedia
> article left me more confused than enlightened.]

We _could_ but that's a lot of extra tests to run for very little gain. So long
as we're doing boundary testing I _think_ what we have is good enough. That
means we should test for a field's absence in N-1, presence in N, and presence
in N+1 (if and when that version exists). I think we're doing relatively good
job of this at the moment so I wouldn't be inclined to change too much, but of
course I'm open to other suggestions :)


> Anyway, patch itself LGTM. I'm trying not to have PW take over my whole work
> day so I haven't done a detailed review.
> Kind regards,
> Daniel

More information about the Patchwork mailing list