Patchwork gets confused about authorship
konstantin at linuxfoundation.org
Fri May 21 03:04:50 AEST 2021
On Thu, May 20, 2021 at 06:15:51PM +0200, Yann E. MORIN wrote:
> With recently noticed that patchwork gets confused about the authorship
> of some patches.
I wouldn't say that it's patchwork that gets confused about the authorship. If
you examine the headers, it's clear that the list causes this problem by
rewriting the "From: " header:
From: "Chan, Donald via buildroot" <buildroot at busybox.net>
The original From: header is completely obliterated, though I expect it's the
list that inserts the following:
Reply-To: "Chan, Donald" <hoiho at lab126.com>
There's not even an X-Original-From: or anything like that, which would help
avoid this problem, since Patchwork will recognize this situation and
correctly substitute the list From with the original From.
> For example:
> has Eugen.Hristev set as author, but it was never sent by then. The
> original mail can be had on our mailing list:
> which was sent by Chan, Donald. So, when we apply patches, they get the
> wrong authorship...
> The mbox link (to use with git-am for example), has the wrong From
> $ curl -s 'https://email@example.com/mbox/' |grep -E '^From:'
> From: "Eugen.Hristev--- via buildroot" <buildroot at busybox.net>
This is because when patchwork received an email with the address
"buildroot at busybox.net" it was sent by Eugen.Hristev -- so the
buildroot at busybox.net account in patchwork has that name associated with it
and will put that into all patches.
Again, not really the problem of patchwork, but the side-effect of how the
> Any idea? How can we avoid that?
You should fix the list to not substitute the From: header with the list
More information about the Patchwork