[PATCH v2 3/5] patch-list: style modification forms as an action bar

Jonathan Nieder jrnieder at gmail.com
Tue Jul 27 12:13:52 AEST 2021

Raxel Gutierrez wrote:

> Added styling to the new patch list html code to make the change
> property and bundle action forms more usable. Before [1] and after [2]
> images for reference.
> [1] https://imgur.com/Pzelipp
> [2] https://imgur.com/UtNJXuf

Ooh, this changes from


	Change state: [no change    v]
	Delegate to:  [no change    v]
	Archive:      [no change    v]


	[Change state v] [Delegate to v] Archived: [No change v] [update]

Good use of vertical space, and this looks more intuitive to work with
since it matches a more usual style for an action bar.

> Signed-off-by: Raxel Gutierrez <raxel at google.com>
> ---
>  htdocs/css/style.css | 77 ++++++++++++++++++++++++++++++++++++--------

I like the CSS changes --- this not only achieves some nice style
changes, but also makes it a bit easier to read in the process and
makes good use of flexboxes to handle reflow reasonably if the page is

> --- a/patchwork/forms.py
> +++ b/patchwork/forms.py

The changes here look reasonable as well.

Reviewed-by: Jonathan Nieder <jrnieder at gmail.com>


More information about the Patchwork mailing list