[PATCH 4/5] static: utils.js for modular handling of requests & messages

Raxel Gutierrez raxel at google.com
Wed Jul 21 03:24:42 AEST 2021


> I think I'd prefer to see this squashed into the same patch as patch
> 5/5, because that way it's easier to evaluate the interface it exposes
> in the context of what its callers need.  I don't feel strongly about
> that, though.  (It mostly comes down to whether the API exposed here
> is obvious enough when viewed without that context.)

I feel that the file is well documented enough and the methods it
exposes are also given enough context for the patch to be on its own.
Patch 5/5 adds a whole new feature to Patchwork which I feel should be
evaluated by itself. Without squashing, both patches can be more
self-contained. Ultimately, I feel that the following patch is more
than just a proof of concept, it's a new feature. This patch simply is
for healthier code as the module's functions will be used elsewhere

More information about the Patchwork mailing list