[RFC PATCH 0/4] patch-detail: add patch relations table

Raxel Gutierrez raxel at google.com
Tue Aug 24 00:58:43 AEST 2021


Currently, Patchwork has the idea of patch relations in the backend. 
Patch relations can only be used and modified with the REST API. This 
RFC patch series introduces a patch relations table that extends 
information from the unaddressed/addressed patch comments status. The 
table is intended (at a basic level) to group the various versions of a 
given patch. With these related patches grouped in a table, users can 
easily see what remains unresolved in moving the patch forward (through 
the unaddressed/addressed comments). Also, reviewers can ensure that 
they are on the latest version of a given patch and see any tags that 
the patch has been given. 

The patch relations table adds manual functionality for adding/removing 
related patches. This helps give users a UI for these changes rather 
than relying on the more complex REST API. There doesn’t exist any 
automated system to relate the same patch across its different versions, 
but it should be implemented in the future. So, later on this tool 
should be used more as a fallback plan when the automated system fails. 

The patch series is an RFC because it isn’t super polished and has some 
behavior that should be discussed. In particular, to fix patch relations 
issues, users that don’t have edit permissions are generated an email to 
send to project maintainers about the issue. This functionality has 
errors at the moment because it doesn’t not fix the patch subject to 
where characters don’t get cut off from the Subject line (e.g. commas 
‘,’ get cut off). Also, it currently emails the patchwork mailing list 
(patchwork at lists.ozlabs.org) but instead should email the specific 
project’s mailing list. Ideas for the ideal behavior for how to fix 
patch relations issues are very welcome. 

Raxel Gutierrez (4):
  patch-detail: add patch relation context
  patch-detail: add patch relations table
  api: modularize patch relations handling
  patch-detail: add functionality to add/remove related patches

 htdocs/css/style.css                          | 120 ++++++++++++-
 htdocs/js/submission.js                       |  41 +++++
 patchwork/api/patch.py                        | 161 +++++++++---------
 patchwork/models.py                           |  36 ++++
 patchwork/templates/patchwork/submission.html |  96 +++++++++++
 patchwork/templatetags/patch.py               |  34 ++--
 patchwork/views/__init__.py                   |  33 ++++
 patchwork/views/patch.py                      |  62 ++++++-
 8 files changed, 491 insertions(+), 92 deletions(-)

-- 
2.33.0.rc2.250.ged5fa647cd-goog



More information about the Patchwork mailing list