[PATCH v3 00/10] patch-detail: add unaddressed/addressed status to patch comments

Raxel Gutierrez raxel at google.com
Sat Aug 14 00:27:05 AEST 2021


On Fri, Aug 13, 2021 at 1:32 AM Raxel Gutierrez <raxel at google.com> wrote:
>
> This series is a revision to the previous version of the patch series.
> The series mainly addresses the review comments from the v2 series [1].
> In doing so, its patches that deal with refactoring and don�t make
> user-facing changes are placed at the beginning of this series to make
> it easier to merge them as their complexity is low.
>
> Since v2:
> - Patch 1: adds refactoring of <pk> to <patch_id>
> - Patch 2: clean up/refactoring of patch detail page
> - Patch 3: adds patch-list.js file to modularize script code in template
> - Patch 4: change patch meta info toggles from link elements to
>   buttons
> - Patch 5: adds dependency patch that adds the JS Cookie library
>   to be able to add csrf tokens to requests made client-side using JS
> - Patch 6: adds rest.js file to modularize the functionality of making
>   REST API requests in the client-side
> - Patch 7: split from [v2 1/5] to only deal with adding addressed field
>   to the PatchComment model and changing it�s edit permissions
> - Patch 8: adds /comments/<comment_id> endpoint and has its tests now
>   too. Also, based on review comments:
>    - fix OpenAPI definition of new `comments/<comment_id> endpoint to
>      not apply to older versions (< v1.3) of the REST API
>    - add motivation of adding addressed field to patch comments & reason
>      behind new endpoint to commit message of patch
>    - remove `addressed: False` from tests/utils.py creation of patch
>      comment
> - Patch 9: combine styling from [v2 3/5] and functionality from [v2 4/5]
>   to add addressed status label and buttons with the ability to update
>   the state manually through the button as before
> - Patch 10: remove preclude section and reword features/api sections
>
> [1] https://lists.ozlabs.org/pipermail/patchwork/2021-July/007001.html
> [2] https://lists.ozlabs.org/pipermail/patchwork/2021-July/006944.html

Forgot to mention the [2] footnote is an earlier thread with a mockup
that redesigns the patch-detail page. Feel free to leave feedback
there :)

[snip range-diff]


More information about the Patchwork mailing list