[PATCH v3 0/5] patch-list: improve usability of list action bar

[Stephen Finucane]

On Wed, 2021-07-28 at 15:24 +0000, Raxel Gutierrez wrote:
> This series is a revision to the previous version of the patch series.
> The series mainly addresses the review comments from the v2 series [1]. 
> 
> For the first patch, the recently released v3.0.0 of the JS cookie 
> library replaces the previous version. 
> 
> For the second patch, following jrnieder’s comments [2], the commit 
> message is updated to better explain the benefits of the change and its
> details. Also, an unclear comment in forms.py for BundleForm is cleaned
> up to better explain what the changes do. The id for <td> table cells in
> patch-list.html are correctly differentiated by patch id. I noticed a 
> bug where property changes in the patch detail page weren’t working
> because the respective “update” action was not accounted for.  
> 
> For the third patch, the “jump to form” arrow is removed [3].
> 
> For the fourth patch, the `updateProperty` function now returns whether
> the update request was successful or not with `response.ok` so that 
> callers can use that information and respond accordingly. The next patch
> adds a use case for the return value.
> 
> For the fifth patch, the inline dropdowns are changed so that they are 
> only visible to logged in users. Also, upon any unsuccessful update
> requests, the dropdown selection reverts to its previous selection.
> Since update requests to a patch’s state and delegate fields fail for
> unauthorized users, this behavior covers the case where unauthorized
> users don't see the current state of the db after they change the
> dropdown selection. This behavior is a useful example of patch four’s
> change of returning whether an update request is successful.
> 
> [1] https://lists.ozlabs.org/pipermail/patchwork/2021-July/006968.html
> [2] https://lists.ozlabs.org/pipermail/patchwork/2021-July/006988.html
> [3] https://lists.ozlabs.org/pipermail/patchwork/2021-July/006991.html

fwiw, I've read the reviews from Daniel on this series and am waiting on v4
before I weigh in.

Stephen