Pain points in Git's patch flow
Junio C Hamano
gitster at pobox.com
Sat Apr 17 05:50:03 AEST 2021
Jonathan Nieder <jrnieder at gmail.com> writes:
> 3. Do you think patchwork goes in a direction that is likely to help
> with these?
So here is a real-life example.
Let's say somebody is looking at a "gentle ping" [*1*]
znh> The patch seems to have fallen into the crack.
zhn> Jeff and Junio, willing to help?
How would we figure out what happened to the patch today without
visiting patchwork would be:
1. Visit the message at lore.kernel.org/git/ [*1*]
2. Notice that it is a response to a message, and click the link to
be taken to [*2*]
3. Notice that nobody commented on the patch.
4. Type "f:zhening ref-filter" to the search box and search, with
suspicion that this was an updated version of something.
5. Click one of them in the result [*3*]
6. This time, we can tell that this seemed to have had two earlier
iterations, and after reading the discussion through, the last
one changed the course in a major way. Not just a new helper
introduced in the earlier rounds has gone away, but an existing
helper got removed.
7. All comments in the discussion for the earlier two rounds can be
read as supporting the new direction the latest round takes.
8. The fact remains that even if the direction has been endorsed
(see 7. above) nobody took a look at the implementation for the
latest round.
9. Make the final verdict.
I use my newsreader to do pretty much the equivalent of the above
without hitting https://lore.kernel.org/git/ but the above is
written to use the web interface, in order to make it reproducible
more easily by anybody on the list.
Now, how can patchwork improve the above reviewer experience, out
of the box and possibly with new helpe rools around it?
I can see #3 would immediately become obvious, and I hope #4-#5
would become unnecessary.
Anything else?
At steps #6 and #7, there is human judgment involved that may not be
automatable, but would there be some mechanism to make it easy to
help these steps if the user visits patchwork (instead of staying
in my newsreader or web interface to the lore archive)?
I am of course not expecting to automate step #9 ;-) It would be
nice though.
Thanks.
[References]
*1* https://lore.kernel.org/git/CAOLTT8Tis5Yjg8UR0c-i0BnqiFQvLXvDgxUQJ-WcP6jjQPu9cQ@mail.gmail.com/
*2* https://lore.kernel.org/git/pull.928.git.1617975348494.gitgitgadget@gmail.com/
*3* https://lore.kernel.org/git/pull.927.v2.git.1617809209164.gitgitgadget@gmail.com/
More information about the Patchwork
mailing list