[PATCH v3 26/29] patman: Support checking for review tags in patchwork

Simon Glass sjg at chromium.org
Wed Nov 4 10:02:48 AEDT 2020


Before sending out a new version of a series for review, it is important
to add any review tags (e.g. Reviewed-by, Acked-by) collected by
patchwork. Otherwise people waste time reviewing the same patch
repeatedly, become frustrated and stop reviewing your patches.

To help with this, add a new 'status' subcommand that checks patchwork
for review tags, showing those which are not present in the local branch.

This allows users to see what new review tags have been received and then
add them.

Sample output:
   $ patman status
     1 Subject 1
       Reviewed-by: Joe Bloggs <joe at napierwallies.co.nz>
     2 Subject 2
       Tested-by: Lord Edmund Blackaddër <weasel at blackadder.org>
       Reviewed-by: Fred Bloggs <f.bloggs at napier.net>
     + Reviewed-by: Mary Bloggs <mary at napierwallies.co.nz>
   1 new response available in patchwork

The '+' indicates a new tag. Colours are used to make it easier to read.

Signed-off-by: Simon Glass <sjg at chromium.org>
---

Changes in v3:
- Rename GetMetaData() function to snake case
- Fix incorrect commenting on a line in prepare_patches()

Changes in v2:
- Adjust the algorithm to handle patch/commit mismatch
- Correct Python style problems
- Use REST API instead of web pages

 tools/patman/README       |  34 ++++
 tools/patman/control.py   |  46 +++++
 tools/patman/func_test.py | 315 +++++++++++++++++++++++++++++++++
 tools/patman/main.py      |  18 ++
 tools/patman/status.py    | 356 ++++++++++++++++++++++++++++++++++++++
 tools/patman/terminal.py  |  21 ++-
 6 files changed, 784 insertions(+), 6 deletions(-)
 create mode 100644 tools/patman/status.py

Applied to u-boot-dm, thanks!


More information about the Patchwork mailing list