[PATCH v2 0/2] Add submission relations

[Daniel Axtens]

Daniel Axtens <dja at axtens.net> writes:

> Stephen Finucane <stephen at that.guru> writes:
>
>> An update of Daniel's changes to add the schema and fix various other
>> things that were off from the RFC.
>>
>> Daniel - can you have a look through this and make sure I haven't missed
>> anything obvious? If not, feel free to apply it and cut RC2.
>
> Applied. While we don't have a fix for the performance issue:
>
>  - we have only limited users for this API
>
>  - the proposed changes to the models don't fix things, so it's not like
>    waiting gives us a clear fix
>
>  - if things go badly wrong it's easy to nop out the whole
>    infrastructure, returning [] for all queries and rejecting all
>    PATCHes.

Turns out this performance issue has always existed in the series view
in the API and no-one has complained, so I'm feeling much more confident
about this decision.

-- d

>
> Thanks everyone for your persistence.
>
> I made 2 minor tweaks:
>
>  1) add prefetches to avoid repeated queries for the project
>  2) change to patch API test query count so tests still pass. There
>     should now be 1 more query to retrieve the relation.
>
> Regards,
> Daniel
>
>>
>> Mete Polat (2):
>>   models, templates: Add patch relations
>>   REST: Add patch relations
>>
>>  docs/api/schemas/latest/patchwork.yaml        |  44 +++
>>  docs/api/schemas/patchwork.j2                 |  60 ++++
>>  docs/api/schemas/v1.1/patchwork.yaml          |  18 +
>>  docs/api/schemas/v1.2/patchwork.yaml          |  44 +++
>>  patchwork/admin.py                            |   8 +
>>  patchwork/api/embedded.py                     |  25 ++
>>  patchwork/api/event.py                        |   8 +-
>>  patchwork/api/patch.py                        | 121 ++++++-
>>  .../migrations/0040_add_related_patches.py    |  41 +++
>>  patchwork/models.py                           |  32 +-
>>  patchwork/signals.py                          |  24 ++
>>  patchwork/templates/patchwork/submission.html |  37 ++
>>  patchwork/tests/api/test_relation.py          | 319 ++++++++++++++++++
>>  patchwork/tests/utils.py                      |  11 +
>>  patchwork/views/patch.py                      |  14 +
>>  .../add-patch-relations-c96bb6c567b416d8.yaml |  11 +
>>  16 files changed, 812 insertions(+), 5 deletions(-)
>>  create mode 100644 patchwork/migrations/0040_add_related_patches.py
>>  create mode 100644 patchwork/tests/api/test_relation.py
>>  create mode 100644 releasenotes/notes/add-patch-relations-c96bb6c567b416d8.yaml
>>
>> -- 
>> 2.24.1
>>
>> _______________________________________________
>> Patchwork mailing list
>> Patchwork at lists.ozlabs.org
>> https://lists.ozlabs.org/listinfo/patchwork