Patchwork v2.0.0-rc1 Available

[Daniel Axtens]

Stephen Finucane <stephen at that.guru> writes:

> On Fri, 2020-02-28 at 13:34 +1100, Daniel Axtens wrote:
>> Stephen Finucane <stephen at that.guru> writes:
>> 
>> > On Wed, 2020-01-29 at 00:15 +1100, Daniel Axtens wrote:
>> > > Stephen Finucane <stephen at that.guru> writes:
>> > > 
>> > > > $subject should read v2.2.0-rc1, clearly :)
>> > > 
>> > > I'd like to see us squash the following before we do 2.2.0:
>> > > 
>> > >  * why does /api/patches/ make N queries for a project's linkname?
>> > > 
>> > >  * given that we have souped-up events, we need to make sure that they
>> > >    don't get accidentally deleted, esp. for things like relations that
>> > >    could actually go away. (on_delete=CASCADE is probably often wrong...)
>> > > 
>> > >  * we need to check that Konstantin's DB murdering query is fixed.
>> > > 
>> > >  * last but not least, I'd like to land Mete's relation work, and I
>> > >    think we're getting close.
>> > > 
>> > > I'm sure there are others but I wanted to dump this mental list lest I
>> > > miss the opportunity.
>> > 
>> > Finally got around to reviewing the last of those, but personally I'd
>> > much rather we cut 2.2.0 now and focused on this and the above for
>> > 3.0.0. Clearly the relations work is important and useful work, but we
>> > haven't had a release in well over a year and the versions of Django we
>> > support are getting cruftier by the day. Two of the other three changes
>> > could in theory be backported post release too. If we cut the release
>> > now, that takes a bit of pressure off and means we won't end up forcing
>> > the relation work through just to get a release out.
>> 
>> I'd like to see relations land, but my top priority is Konstantin's
>> DB-murdering query.
>
> Have we anything ready for this though? If not, could we push out 2.2.0
> and fix this in a latter release? I mean, it's no more broken than
> before and may be better thanks to Stuart's DB query optimizations.

I honestly haven't looked, so I guess I'll give it a quick spin over the
next couple of days.

>
>> It's unfortunate that we don't have more time to work on this, but I am
>> actively trying not to feel guilty about it: if Patchwork development
>> really matters to someone with a business-critical need, they can fund
>> someone to work on it. Until then, it's a best-effort enterprise.

>
> Agreed. v2.2.0 can be best effort too :)
>

In that vein, I think let's just commit the relations work - it is a bit
db-inefficient still, but seeing as that will only become an issue if
relations become wildly popular, let's accept the inefficiency for now
and hope for the best. I'll double check your latest series on it and
spin -rc2. I will aim to have this done by the end of the week.

> I just want to get this out now,

Fair.

Daniel
>
> Stephen
>
>> Daniel
>> > Thoughts?
>> > Stephen
>> > 
>> > > Regards,
>> > > Daniel
>> > > 
>> > > > Stephen
>> > > > 
>> > > > On Fri, 2019-12-27 at 18:17 +0000, Stephen Finucane wrote:
>> > > > > The first release candidate of the upcoming Patchwork v2.2.0 release
>> > > > > is
>> > > > > now available:
>> > > > > 
>> > > > >     https://github.com/getpatchwork/patchwork/releases/tag/v2.2.0-rc1
>> > > > > 
>> > > > > This release includes a large number of changes, including:
>> > > > > 
>> > > > >  * Support for new versions of Django, Django REST Framework, and
>> > > > >    Django Filter
>> > > > >  * Multiple bugfixes
>> > > > > 
>> > > > > We look forward to any feedback on this release. Barring any critical
>> > > > > issues, the final release will be cut at the end of this month.
>> > > > > 
>> > > > > Happy patchworking!
>> > > > > 
>> > > > > ---
>> > > > > 
>> > > > > Patchwork is a patch tracking system for community-based projects. It
>> > > > > is intended to make the patch management process easier for both the
>> > > > > project's contributors and maintainers, leaving time for the more
>> > > > > important (and more interesting) stuff. You can find out more on the
>> > > > > GitHub repo [1], the docs [2], or the original project homepage [3].
>> > > > > 
>> > > > > [1]: https://github.com/getpatchwork/patchwork
>> > > > > [2]: https://patchwork.readthedocs.org/
>> > > > > [3]: http://jk.ozlabs.org/projects/patchwork/
>> > > > > 
>> > > > > _______________________________________________
>> > > > > Patchwork mailing list
>> > > > > Patchwork at lists.ozlabs.org
>> > > > > https://lists.ozlabs.org/listinfo/patchwork
>> > > > 
>> > > > _______________________________________________
>> > > > Patchwork mailing list
>> > > > Patchwork at lists.ozlabs.org
>> > > > https://lists.ozlabs.org/listinfo/patchwork