[PATCH 2/2] api: allow filtering patches and covers by msgid

Daniel Axtens dja at axtens.net
Tue Apr 14 23:27:08 AEST 2020


Stephen Finucane <stephen at that.guru> writes:

> On Tue, 2020-04-14 at 16:21 +1000, Daniel Axtens wrote:
>> In the process of fixing the previous bug, I realised that:
>> 
>>  a) /api/patches/msgid is a perfectly reasonable thing to attempt
>>  b) We have no way of finding a patch by message id in the API
>> 
>> We can't actualy make /api/patches/msgid work because it may not
>> be unique, but we can add a filter.
>> 
>> I'm shoehorning this into stable/2.2, even though it's technically
>> an API change: it's minor, not incompatible and in hindsight a
>> glaring hole.
>> 
>> Cc: Michael Ellerman <mpe at ellerman.id.au>
>> Signed-off-by: Daniel Axtens <dja at axtens.net>
>
> I meant to do this before cutting v2.2.0 and forgot. Probably should
> have had a list.
>
> It's not ideal putting this into an already released API version, but I
> agree it's a huge oversight. Let's make sure we get v2.2.1 out nice and
> quickly.

Indeed, doing this now.

Thanks!

Regards,
Daniel

>
> Reviewed-by: Stephen Finucane <stephen at that.guru>
>
> Stephen


More information about the Patchwork mailing list