[PATCH] sql: Fix table lists

Ali Alnubani alialnu at mellanox.com
Sun Sep 8 17:13:22 AEST 2019


Thanks Stephen.

I see the following section in the docs https://patchwork.readthedocs.io/en/latest/deployment/installation/#mail-transfer-agent-mta:
"""
This assumes your Postfix process is running as the nobody user. If this is not correct (use of postfix user is also common), you should change both the username in the createuser command above and substitute the username in the grant-all-postgres.sql script with the appropriate alternative.
"""
But I believe that it doesn’t have to be the user running the postfix process,
It's the permissions defined by postfix's conf default_privs:
http://www.postfix.org/postconf.5.html#default_privs

Can you confirm my thought?

Thanks,
Ali

> -----Original Message-----
> From: Stephen Finucane <stephen at that.guru>
> Sent: Friday, September 6, 2019 4:31 PM
> To: Ali Alnubani <alialnu at mellanox.com>; patchwork at lists.ozlabs.org
> Cc: Thomas Monjalon <thomas at monjalon.net>
> Subject: Re: [PATCH] sql: Fix table lists
> 
> On Wed, 2019-09-04 at 13:40 +0000, Ali Alnubani wrote:
> > The patch adds missing commas in the table lists where missing, and
> > removes where unnecessary.
> > This fixes errors such as the following when feeding the script to
> > psql:
> >
> > ```
> > psql:lib/sql/grant-all.postgres.sql:37: ERROR:  syntax error at or
> > near "patchwork_emailconfirmation"
> > LINE 19:  patchwork_emailconfirmation, ...
> > ```
> >
> > Fixes: ca0e79d4db34 ("sql: Sort 'grant-all' scripts alphabetically")
> >
> > Signed-off-by: Ali Alnubani <alialnu at mellanox.com>
> 
> Nicely done. Applied and backported to stable/2.1.
> 
> Thanks!
> 
> Stephen



More information about the Patchwork mailing list