[PATCH] sql: Fix table lists

[Ali Alnubani]

Hi Stephen,

> -----Original Message-----
> From: Stephen Finucane <stephen at that.guru>
> Sent: Sunday, September 8, 2019 8:51 PM
> To: Ali Alnubani <alialnu at mellanox.com>; patchwork at lists.ozlabs.org
> Cc: Thomas Monjalon <thomas at monjalon.net>
> Subject: Re: [PATCH] sql: Fix table lists
> 
> On Sun, 2019-09-08 at 07:13 +0000, Ali Alnubani wrote:
> > Thanks Stephen.
> >
> > I see the following section in the docs
> https://patchwork.readthedocs.io/en/latest/deployment/installation/#mail-
> transfer-agent-mta:
> > """
> > This assumes your Postfix process is running as the nobody user. If
> > this is not correct (use of postfix user is also common), you should
> > change both the username in the createuser command above and
> > substitute the username in the grant-all-postgres.sql script with the
> > appropriate alternative.
> > """
> > But I believe that it doesn’t have to be the user running the postfix
> > process, It's the permissions defined by postfix's conf default_privs:
> > http://www.postfix.org/postconf.5.html#default_privs
> >
> > Can you confirm my thought?
> 
> To be honest, I'll have to let somone else answer this. I wrote that quite a
> long time ago and haven't really touched it since, so I've long since forgotten
> the reason I included that /o\ What you've said does make sense though, so
> if you've tested it and it works as expected or you can find a blog that says
> the same thing, I'd be happy to accept a patch to correct this.
> 
> Sorry I can't be of more help,
> Stephen

I just sent a patch http://patchwork.ozlabs.org/patch/1180692/. 

> 
> > Thanks,
> > Ali
> >
> > > -----Original Message-----
> > > From: Stephen Finucane <stephen at that.guru>
> > > Sent: Friday, September 6, 2019 4:31 PM
> > > To: Ali Alnubani <alialnu at mellanox.com>; patchwork at lists.ozlabs.org
> > > Cc: Thomas Monjalon <thomas at monjalon.net>
> > > Subject: Re: [PATCH] sql: Fix table lists
> > >
> > > On Wed, 2019-09-04 at 13:40 +0000, Ali Alnubani wrote:
> > > > The patch adds missing commas in the table lists where missing,
> > > > and removes where unnecessary.
> > > > This fixes errors such as the following when feeding the script to
> > > > psql:
> > > >
> > > > ```
> > > > psql:lib/sql/grant-all.postgres.sql:37: ERROR:  syntax error at or
> > > > near "patchwork_emailconfirmation"
> > > > LINE 19:  patchwork_emailconfirmation, ...
> > > > ```
> > > >
> > > > Fixes: ca0e79d4db34 ("sql: Sort 'grant-all' scripts
> > > > alphabetically")
> > > >
> > > > Signed-off-by: Ali Alnubani <alialnu at mellanox.com>
> > >
> > > Nicely done. Applied and backported to stable/2.1.

The patch doesn't seem to be in stable/2.1 yet. I also noticed that it doesn't apply there.
Let me know if you want me to backport it.

> > >
> > > Thanks!
> > >
> > > Stephen

Thanks,
Ali