[PATCH] tests: Rename inaccurately named test_patchwork_from_header

Daniel Axtens dja at axtens.net
Fri Oct 18 15:02:24 AEDT 2019


Andrew Donnellan <ajd at linux.ibm.com> writes:

> The test_patchwork_from_header test claims to test for the presence of the
> X-Patchwork-From header, when we actually call it X-Patchwork-Sender.
X-Patchwork-Submitter, surely?

(I didn't even know that one existed!)

Regards,
Daniel
>
> Fix it.
>
> Signed-off-by: Andrew Donnellan <ajd at linux.ibm.com>
> ---
>  patchwork/tests/test_mboxviews.py | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/patchwork/tests/test_mboxviews.py b/patchwork/tests/test_mboxviews.py
> index 3854a856c4db..ab0c1669944f 100644
> --- a/patchwork/tests/test_mboxviews.py
> +++ b/patchwork/tests/test_mboxviews.py
> @@ -153,8 +153,8 @@ class MboxHeaderTest(TestCase):
>                                          patch.url_msgid]))
>          self.assertContains(response, 'X-Patchwork-Delegate: %s' % user.email)
>  
> -    def test_patchwork_from_header(self):
> -        """Validate inclusion of generated 'X-Patchwork-From' header."""
> +    def test_patchwork_submitter_header(self):
> +        """Validate inclusion of generated 'X-Patchwork-Submitter' header."""
>          email = 'jon at doe.com'
>          from_header = 'From: Jon Doe <%s>\n' % email
>  
> -- 
> 2.20.1
>
> _______________________________________________
> Patchwork mailing list
> Patchwork at lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/patchwork


More information about the Patchwork mailing list