[PATCH v2 0/3] Store the 'actor' responsible for events
Daniel Axtens
dja at axtens.net
Thu Oct 17 08:23:26 AEDT 2019
>> There is still an open discussion as to whether the strategy used in
>> patch #2 to determine the actor and forward it to the event creation,
>> is the way we want to go.
>>
>>
>> Have fun!
>> ...Johan
>
> Hi Daniel/Stephen,
>
> Any news with regards to this patchset? This is a long-waited feature that
> we need on media, in order to allow more people to be able to change
> status at our patchwork instance.
I'm happy for it to go in for 2.2, I was just waiting to see if Stephen
had any thoughts on:
>> There is still an open discussion as to whether the strategy used in
>> patch #2 to determine the actor and forward it to the event creation,
>> is the way we want to go.
It's a bit ugly but I have no better ideas, so if Stephen is OK with it
I am too. The only review comments I still had were just to unwire the
patch-created event (and perhaps one or two related ones) that we expect
to always be triggered by parse{mail,archive}.
Regards,
Daniel
>
> Regards,
> Mauro
>
>>
>>
>> Johan Herland (3):
>> models.Event: Add the user responsible for the event
>> Include the responsible actor in applicable events
>> /api/events: Add 'actor' field to generated JSON
>>
>> docs/api/schemas/latest/patchwork.yaml | 6 ++++++
>> docs/api/schemas/patchwork.j2 | 8 ++++++++
>> docs/api/schemas/v1.2/patchwork.yaml | 6 ++++++
>> patchwork/api/event.py | 10 +++++++---
>> patchwork/migrations/0037_event_actor.py | 21 +++++++++++++++++++++
>> patchwork/models.py | 10 +++++++++-
>> patchwork/signals.py | 10 ++++++++--
>> patchwork/tests/api/test_event.py | 24 ++++++++++++++++++++++++
>> patchwork/tests/test_events.py | 7 +++++++
>> 9 files changed, 96 insertions(+), 6 deletions(-)
>> create mode 100644 patchwork/migrations/0037_event_actor.py
>>
>
>
>
> Thanks,
> Mauro
More information about the Patchwork
mailing list