RFE: use patchwork to submit a patch
rostedt at goodmis.org
Sat Oct 12 05:44:01 AEDT 2019
On Fri, 11 Oct 2019 11:32:54 -0700 (PDT)
David Miller <davem at davemloft.net> wrote:
> From: Steven Rostedt <rostedt at goodmis.org>
> Date: Fri, 11 Oct 2019 14:01:08 -0400
> > Thus, if we want people to send us their fixes, we better keep just
> > an email with a patch the lowest bar for entry.
> I argue that for people coming into the software engineering world
> today, a PR is the lowest bar for entry. And email is the exact
> opposite, _especially_ our way of doing email.
> Because it IS NOT just an email with a patch.
That is if the maintainer wants to be anal about the submission. I've
taken patches where I only asked the person to give me a signed off by.
I also ask:
"Hi, do you intend on being a contributor, or do you only want to get
this fix upstream? If the latter, I will handle the change log and
other formatting for you, all I need is the signed-off-by. Otherwise, I
will help you submit a proper patch."
Again, this is for one offs, where someone found something like an off
by one error or other trivial bug to fix. I just want the fix in, but
will let the submitter decide how strict I will be to get it in. I've
had people say "I don't care, just get it fixed", and I do the
formatting and all the grudge work, but still give the submitter the
Not to mention, there's several times I get a patch where the solution
is totally wrong, and I need to make the fix anyway. A simple
Reported-by is what the submitter gets. Also, perfectly done by email.
> You are not helping casual contributors with this "simple" email based
> submission method. It is understood and easy us, but nobody else.
I'm not saying that email is the only way, this entire thread is about
getting another tool to help. But I will scream very loudly if we
eliminate email totally.
More information about the Patchwork