[PATCH v3 0/3] Store the 'actor' responsible for events
johan at herland.net
Tue Nov 12 05:30:20 AEDT 2019
On Fri, Oct 18, 2019 at 8:29 AM Daniel Axtens <dja at axtens.net> wrote:
> Johan Herland <johan at herland.net> writes:
> > The V4L project (https://patchwork.linuxtv.org) uses patch states and
> > delegates extensively to track progress. We want an audit log to keep
> > track of the changes made to these patch fields. The Event model already
> > records this information, but leaves out one crucial detail: which
> > maintainer/user actually updated the patch state/delegate. The need for
> > this enhancement is also documented in Issue #73.
> > This patch series adds an 'actor' field to the Event model, and - for
> > applicable events - stores the user responsible for that event (i.e. the
> > current/active user, if any) into this field.
> > This applies to the following events:
> > - patch-created
> > - patch-completed
> > - patch-state-changed
> > - patch-delegated
> > - series-completed
> > - check-created
> I keep going back and forth about the sets of events. I still think
> patch-created is an odd event to try to audit, but OTOH I think setting
> a precedent of including every event in the audit trail will make it
> easier to (remember to) extend this in future - I'm particularly
> thinking about the upcoming relations stuff, which we will definitely
> want to include in the audit trail.
> Stephen, what are your thoughts?
More information about the Patchwork