RFE: use patchwork to submit a patch

[Dmitry Vyukov]

On Fri, Nov 8, 2019 at 3:11 PM Dmitry Vyukov <dvyukov at google.com> wrote:
>
> On Fri, Nov 8, 2019 at 3:02 PM Theodore Y. Ts'o <tytso at mit.edu> wrote:
> >
> > On Fri, Nov 08, 2019 at 10:44:25AM +0100, Dmitry Vyukov wrote:
> > > syzbot asks to provide fixing commit in a particular format (and on 1
> > > line, otherwise not possible to parse back).
> > >
> > > It sent this yesterday:
> > > https://groups.google.com/forum/message/raw?msg=syzkaller-bugs/IZZUu-BobtI/xAkxm6H4EQAJ
> >
> > This is Shuah's reply, not the syzbot original message.  Looks like
> > you cut and pasted the same URL twice?
> >
> > The correct URL is:
> >
> > https://groups.google.com/forum/message/raw?msg=syzkaller-bugs/IZZUu-BobtI/wQdqUSHuEQAJ
> >
> > .. and it looks like what Syzbot sent was already line-wrapped:
> >
> > >If the result looks correct, please mark the bug fixed by replying with:
> > >
> > >#syz fix: usb: usbip: Fix BUG: KASAN: slab-out-of-bounds in
> > >vhci_hub_control()
> >
> > So I don't think you can blame this on how Shuah replied, or how
> > Mozilla handled things.  It looks like either Syzbot or more likely,
> > GMail on its outgoing path "added value" by line-wrapping the message,
> > probably because of the following MIME setting:
> >
> > > Content-Type: text/plain; charset="UTF-8"; format=flowed; delsp=yes
> >
> > Flowing text lines and deleting spaces is always, ALWAYS, a bad idea
> > when sending plain text.  In this case, it wasn't just a patch that
> > got corrupted, but the instructions from Syzbot, which it appears
> > Shuah followed faithfully.  :-)
>
> Looks correct to me. See the DelSp=yes part here:
> https://tools.ietf.org/html/rfc3676
> But I agree this is insanity. But that's exactly the point.

Just to clarify: syzbot does not do this on purpose. It generates and
hands off unwrapped lines. The "format=flowed; delsp=yes" part was
done by somebody else.

> > IBM handled this problem by standing up an open source e-mail system
> > because Lotus Notes couldn't be fixed.  If we can't fix GMail, then
> > David Miller may be right, and e-mail may be doomed.  (I don't like
> > that answer myself, since so far all of the alternatives seem to be
> > categorically worse for our use case, but...)
> >
> >                                                 - Ted