[PATCH 2/2] templates: Specify language

Wed Nov 6 17:17:45 AEDT 2019

Stephen Finucane <stephen at that.guru> writes:

> On Thu, 2019-10-31 at 17:57 +1100, Andrew Donnellan wrote:
>> Specifying language in the <html> tag is recommended in HTML5.
>> 
>> Signed-off-by: Andrew Donnellan <ajd at linux.ibm.com>
>> ---
>>  templates/base.html | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/templates/base.html b/templates/base.html
>> index 01b0d6b5e598..40b6cda65350 100644
>> --- a/templates/base.html
>> +++ b/templates/base.html
>> @@ -1,6 +1,6 @@
>>  {% load static %}
>>  <!DOCTYPE html>
>> -<html xmlns="http://www.w3.org/1999/xhtml">
>> +<html xmlns="http://www.w3.org/1999/xhtml" lang="en-AU">
>
> It's a nit and I know this is applied, but can we change this to en-US? 
> We've a large international audience working on and using Patchwork,
> and I think all of our UI should be written with US spelling in mind.
> en-AU doesn't mean anything to me, personally.

I think this is a nice nod to the original authorship of Patchwork
(Australian) and the original and longest running deployment (OzLabs,
Australia).

I also think the internet already has enough American localisation :)

I'd be happy to see this moved into a settings file like the default
timezone, then sites can override it.

Daniel

> Stephen
>
>>   <head>
>>    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8"/>
>>    <title>{% block title %}Patchwork{% endblock %} - Patchwork</title>
>
> _______________________________________________
> Patchwork mailing list
> Patchwork at lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/patchwork