[PATCH v3 1/5] ui: Retain table header position on size changes

Daniel Axtens dja at axtens.net
Fri Nov 1 00:27:56 AEDT 2019


Hi Mete,

Apologies for the delay in getting back to you. I'm kicking the tyres of
this, so I'll have a few comments across the series. Maybe hold off on
doing a new version until I get through the whole series - I don't want
to waste your effort on doing lots of respins on trivial bits.

> Prevents table header labels from moving up and down when hiding or
> showing additional information for a patch.

This is good. I'll probably pick it out and merge it individually in the
next couple of days.

Reviewed-by: Daniel Axtens <dja at axtens.net>

Regards,
Daniel
>
> Signed-off-by: Mete Polat <metepolat2000 at gmail.com>
> ---
>  htdocs/css/style.css | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/htdocs/css/style.css b/htdocs/css/style.css
> index fc816d3..b9fb9eb 100644
> --- a/htdocs/css/style.css
> +++ b/htdocs/css/style.css
> @@ -189,7 +189,7 @@ table.patchmeta th {
>  table.patchmeta tr th, table.patchmeta tr td {
>      text-align: left;
>      padding: 1px 10px;
> -    vertical-align: middle;
> +    vertical-align: top;
>  }
>  
>  .patchrelations ul {
> -- 
> 2.23.0
>
> _______________________________________________
> Patchwork mailing list
> Patchwork at lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/patchwork


More information about the Patchwork mailing list