[PATCH] parser: recognise git commit consisting only of empty new file

Stephen Finucane stephen at that.guru
Thu Mar 7 22:53:55 AEDT 2019


On Thu, 2019-03-07 at 14:01 +1100, Daniel Axtens wrote:
> Stephen Finucane <stephen at that.guru> writes:
> 
> > On Thu, 2019-02-28 at 15:29 +1100, Daniel Axtens wrote:
> > > Commits with only an empty new file are liable to be missed.
> > > The parser state machine doesn't recognise the headers "new
> > > file mode" and "index": teach it about them.
> > > 
> > > Add a test to demonstrate.
> > > 
> > > It's a little bit academic as you don't usually send patches like
> > > that but sometimes you do, especially if you're a snowpatch dev :)
> > > 
> > > Closes: #256
> > > Reported-by: Andrew Donnellan <andrew.donnellan at au1.ibm.com>
> > > Signed-off-by: Daniel Axtens <dja at axtens.net>
> > 
> > Reviewed-by: Stephen Finucane <stephen at that.guru>
> > 
> > ...and applied. Thanks!
> 
> Thanks! Should we apply this to stable as well? (I'm happy to do the
> legwork and apply it if you're OK with it.)
> 
> Regards,
> Daniel

Already done [1] :) I guess we should cut another release there
shortly. Might be almost time for a v2.2.0 too?

Stephen

[1] https://github.com/getpatchwork/patchwork/commit/0c60d688d0ac3cf41477970b9c8d299ef1d4227b



More information about the Patchwork mailing list