[PATCH v3 0/5] Add submission relations

Mete Polat metepolat2000 at gmail.com
Tue Dec 3 21:02:24 AEDT 2019


Hi Stephen,

On 30.11.19 18:19, Stephen Finucane wrote:
> On Sun, 2019-10-20 at 20:57 +0200, Mete Polat wrote:
>> This patch introduces the ability to view relations between submissions by
>> creating and updating them via the REST API.
>>
>> Changes since v2 (note: forgot to mark the previous revision as v2)
>> - Replace a mistakenly placed tab intention in styles.css with spaces
>> - Fix typo in commit message header
>> - Fix AttributeError caused when viewing a patch with no relations
>> - Remove duplicate 'detailed view' link in submissions.html
>>
>> Changes since v1:
>> - Allow cover letters to be in relations as well (submission relations)
>> - Move from Django permission to a maintainer based one (and update tests)
>> - Drop bulk support
>>   I decided to drop the bulk support in favour of an easier implementation,
>>   usability and maintainability.
>> - Drop support for manually setting relation id
>> - Group relations from other projects separately
>> - Split up UI changes
> 
> I've been a bit out of the loop on this, so could anyone update me on
> the status of this? Is this still in progress and, if so, is this
> something we should be holding Patchwork 2.2 for or can we kick this to
> 3.0?
> 

The next revision is currently in work and I would be grateful if we get
this into 2.2. I am also waiting for a reply by Daniel regarding to some
technical questions (see [PATCH v3 5/5] REST: Add submission relations).

Best regards,

Mete
	
> Stephen
> 
>> Mete Polat (5):
>>   ui: Retain table header position on size changes
>>   ui, templates: Combine series and related row
>>   models, templates: Add submission relations
>>   docs: Add missing series index schema
>>   REST: Add submission relations
>>
>>  docs/api/schemas/latest/patchwork.yaml        | 223 +++++++++++++++++
>>  docs/api/schemas/patchwork.j2                 | 235 ++++++++++++++++++
>>  docs/api/schemas/v1.0/patchwork.yaml          |   5 +
>>  docs/api/schemas/v1.1/patchwork.yaml          |   5 +
>>  docs/api/schemas/v1.2/patchwork.yaml          | 223 +++++++++++++++++
>>  htdocs/css/style.css                          |   4 +-
>>  patchwork/api/index.py                        |   1 +
>>  patchwork/api/relation.py                     |  73 ++++++
>>  .../migrations/0037_submission_relations.py   |  28 +++
>>  patchwork/models.py                           |   9 +
>>  patchwork/templates/patchwork/submission.html |  96 ++++---
>>  patchwork/tests/api/test_relation.py          | 194 +++++++++++++++
>>  patchwork/tests/utils.py                      |  11 +
>>  patchwork/urls.py                             |  11 +
>>  patchwork/views/patch.py                      |   7 +
>>  ...submission-relations-c96bb6c567b416d8.yaml |  10 +
>>  16 files changed, 1101 insertions(+), 34 deletions(-)
>>  create mode 100644 patchwork/api/relation.py
>>  create mode 100644 patchwork/migrations/0037_submission_relations.py
>>  create mode 100644 patchwork/tests/api/test_relation.py
>>  create mode 100644 releasenotes/notes/add-submission-relations-c96bb6c567b416d8.yaml
>>
> 


More information about the Patchwork mailing list