Wrong series name applied to a patch series
dja at axtens.net
Sat Aug 31 01:22:55 AEST 2019
Hi Bin Meng,
> As you can see below:
> The series name is wrongly set to the title of the patch [01/30]:
> riscv: hw: Remove superfluous "linux, phandle" property
> But the series name should really be set to the tile of the cover
> letter's [00/30]:
> riscv: sifive_u: Improve the emulation fidelity of sifive_u machine
> See the QEMU mailing list archive for the above series:
> A similar issue happened with v4 of the same patch series.
> This is the patch [01/28] and its series name is set to the patch name itself
> This is the reset of the v4 patch series, and the series name is set
> to the cover letter [00/28].
> However they all belong to the same patch series.
> So the parsing logic of patchwork has something wrong.
Thanks for pointing this out. I'll have a more detailed look when I get
a minute, but we do have some known issues around parallelism: if
multiple messages are being parsed at the same time, we can end up
getting things wrong, and this happens from time to time on
OzLabs. That's probably what went wrong... although it is weird for it
to happen to multiple revisions of the same series... anyway as I say
I'll take a look when I get a chance.
> For the latter case, what I might guess is happening is that [01/28]
> hit the list before [00/28], so there was no series to append to.
> But even if that's the case, I think patchwork has all the information
> and can still correct the mistake later when it sees all other
> message's "In-Reply-To"s are referring to the same cover letter and
> should group them into one series.
... and we do have code to do this, which is what makes me a bit
suspicious that you've just lost a race.
More information about the Patchwork