[PATCH] models: Add commit_url_format to Project

Daniel Axtens dja at axtens.net
Thu Aug 22 11:55:09 AEST 2019

Michael Ellerman <mpe at ellerman.id.au> writes:

> Andrew Donnellan <ajd at linux.ibm.com> writes:
>> On 7/8/19 9:22 am, Andrew Donnellan wrote:
>>> On 6/8/19 10:20 pm, Michael Ellerman wrote:
>>>> Add a new field to Project, commit_url_format, which specifies a
>>>> format string that can be used to generate a link to a particular
>>>> commit for a project.
>>>> This is used in the display of a patch, to render the patch's commit
>>>> as a clickable link back to the commit on the SCM website.
>>>> Signed-off-by: Michael Ellerman <mpe at ellerman.id.au>
>>> Argh, I've actually got a series of my own pending to do exactly this, 
>>> just had to tidy up the documentation before sending it :)
>>> I'll take a look at this and compare later today.
>> I correct myself, I have patches to add mailing list archive links, 
>> which is slightly different!
> Phew!
>> My series includes a minor bump to the API versioning, which per 
>> docs/development/releasing.rst is our policy when adding new fields. 
>> I'll tidy that up and send it and perhaps you can rebase your API 
>> changes on top of that?
> Sure, just let me know.

It looks like you're going to do a v2 anyway to mesh with Andrew's
changes - please could you pop in update to the fixtures that
demonstrates/exercises this? 

I've had a look at the mark_safe bit. I don't love it - it allows
someone with priv-esc to admin to XSS everyone who visits a patch
page. Having said that I'm not entirely sure what the best way to handle
it is. Andrew you did a few follow-up patches for our XSS adventures -
do you have any thoughts?


> cheers
> _______________________________________________
> Patchwork mailing list
> Patchwork at lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/patchwork

More information about the Patchwork mailing list