Debugging dropped mails

[Veronika Kabatova]

----- Original Message -----
> From: "Petr Vorel" <pvorel at suse.cz>
> To: "Veronika Kabatova" <vkabatov at redhat.com>
> Cc: "Konstantin Ryabitsev" <konstantin at linuxfoundation.org>, patchwork at lists.ozlabs.org, "Jeremy Kerr"
> <jk at ozlabs.org>
> Sent: Wednesday, April 10, 2019 3:50:25 PM
> Subject: Re: Debugging dropped mails
> 
> Hi Veronika,
> 
> > checking the emails you linked and Patchwork's parser method [0], it's not
> > that the emails are lost but rather the diffs are not recognized and thus
> > dropped (verified by testing it with internal Patchwork instance I
> > maintain).
> 
> > The "old mode" line doesn't match any of [1] and thus it looks to Patchwork
> > as
> > if the patch was empty.
> 
> > I'm inclined to say that Patchwork parsing should support all of the
> > extended
> > header lines described in git docs [2] and that the current behavior is a
> > bug.
> Thanks for debugging! I agree that this is a bug and should be fixed.
> And this probably explain my problems with kernel.org instance. But it does
> not
> explain my problems with ozlabs instance start with index:
> Patches not taken (from my gmail address) to LTP: [3], [4]. There are not in
> patchwork [5]. Last ok from gmail was this one [6], taken here [7].
> I also have problem to send mails to Buildroot [8] (haven't tested with suse
> address).
> I guess I had problems with LTP for some time, Buildroot started quite
> recently.
> 
> Any idea what can be a problem?
> 

My 2.1 instance eats the linked patch just fine. The Ozlabs instance is running
version 2.0.2 and there were a few parser fixes and changes introduced in later
releases. Maybe the problem was fixed there?

Unfortunately I can't help you more as I don't see an obvious issue with the
patch nor do I have access to the Ozlabs instance.


Veronika

> > Hope this helps,
> > Veronika
> 
> 
> > [0]
> > https://github.com/getpatchwork/patchwork/blob/master/patchwork/parser.py#L717
> > [1]
> > https://github.com/getpatchwork/patchwork/blob/master/patchwork/parser.py#L785
> > [2] https://git-scm.com/docs/git-diff#_generating_patches_with_p
> 
> Kind regards,
> Petr
> 
> [3] http://lists.linux.it/pipermail/ltp/2019-March/011448.html
> [4] http://lists.linux.it/pipermail/ltp/2019-March/011489.html
> [5] https://patchwork.ozlabs.org/project/ltp/list/?submitter=70792&state=*
> [6] http://lists.linux.it/pipermail/ltp/2019-March/011450.html
> [7] https://patchwork.ozlabs.org/patch/1060538/
> [8] http://lists.busybox.net/pipermail/buildroot/2019-March/245679.html
>