Debugging dropped mails

[Veronika Kabatova]

----- Original Message -----
> From: "Petr Vorel" <pvorel at suse.cz>
> To: "Konstantin Ryabitsev" <konstantin at linuxfoundation.org>, patchwork at lists.ozlabs.org
> Cc: "Jeremy Kerr" <jk at ozlabs.org>
> Sent: Wednesday, April 10, 2019 11:20:00 AM
> Subject: Re: Debugging dropped mails
> 
> Hi Konstantin,
> 
> > On Tue, Apr 09, 2019 at 08:20:19PM +0200, Petr Vorel wrote:
> > > any idea how can I debug dropped mails in patchwork instances?
> > > Few weeks ago I started to be unable to get patches to
> > > patchwork.ozlabs.org and
> > > patchwork.kernel.org. Sometimes only gmail.com address is having
> > > troubles,
> > > sometimes both my email addresses (I cc my gmail address).
> 
> > > Of course, I'm registered to mailing lists, I see my mail in mailing list
> > > archives. Problems are on some kernel mailing lists, but on others as
> > > well
> > > (buildroot, LTP).
> 
> > Can you give me a link to one of the messages that show up in mailing
> > list archives but aren't on patchwork.kernel.org?
> Sure. It's this patch, send from both my mails to linux-kbuild: suse [1],
> gmail [2].
> It's not in patchwork [3]
> 

Hi,

checking the emails you linked and Patchwork's parser method [0], it's not
that the emails are lost but rather the diffs are not recognized and thus
dropped (verified by testing it with internal Patchwork instance I maintain).

The "old mode" line doesn't match any of [1] and thus it looks to Patchwork as
if the patch was empty.

I'm inclined to say that Patchwork parsing should support all of the extended
header lines described in git docs [2] and that the current behavior is a bug.



Hope this helps,
Veronika


[0] https://github.com/getpatchwork/patchwork/blob/master/patchwork/parser.py#L717
[1] https://github.com/getpatchwork/patchwork/blob/master/patchwork/parser.py#L785
[2] https://git-scm.com/docs/git-diff#_generating_patches_with_p

> Kind regards,
> Petr
> 
> [1] https://marc.info/?l=linux-kbuild&m=155467856208923&w=2
> [2] https://marc.info/?l=linux-kbuild&m=155479414711694&w=2
> [3]
> https://patchwork.kernel.org/project/linux-kbuild/list/?series=&submitter=172899&state=*&q=&archive=&delegate=
> _______________________________________________
> Patchwork mailing list
> Patchwork at lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/patchwork
>