[PATCH v2 1/2] parsearchive: Fix logging

Daniel Axtens dja at axtens.net
Sat Sep 22 01:18:47 AEST 2018


Stephen Finucane <stephen at that.guru> writes:

> On Sat, 2018-09-22 at 00:22 +1000, Daniel Axtens wrote:
>> Hi Stephen,
>> 
>> > I've rebased a couple of things onto these two patches and am starting
>> > to rely on it locally, so I'm just going to apply both. It's easy to
>> > revert either of the if necessary.
>> 
>> They're breaking the build:
>> 
>> https://travis-ci.org/getpatchwork/patchwork/jobs/431231311#L486
>> 
>> I don't think it's worth reverting them because of this, but please
>> could you do a fixup?
>
> Yup, will take a look at this this evening. I saw it last night but it
> was too late to investigate it. This didn't happen locally so I'm
> guessing the issue is something to do with how Travis runs things.
> Worst case scenario, I will revert and can retry later.

I can repro at least the pep8 stuff with
docker-compose run web --tox -e pep8

That seems to highlight the issue that ends up erroring the test, so
fixing the pep8 warnings should hopefully be sufficient.

Regards,
Daniel

>
> Stephen
>
>> Regards,
>> Daniel
>> > 
>> > Stephen


More information about the Patchwork mailing list