[PATCH] tests: Remove useless todo

Stephen Finucane stephen at that.guru
Tue Sep 11 09:13:50 AEST 2018


I'm not sure why I included this in day one: we _want_ to use the
context manager like this.

Signed-off-by: Stephen Finucane <stephen at that.guru>
---
 patchwork/tests/test_about.py | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/patchwork/tests/test_about.py b/patchwork/tests/test_about.py
index 956d0324..ba8fd982 100644
--- a/patchwork/tests/test_about.py
+++ b/patchwork/tests/test_about.py
@@ -41,9 +41,6 @@ class AboutViewTest(TestCase):
             self.assertTrue(response.context['enabled_apis']['xmlrpc'])
 
     def test_rest(self):
-        # TODO(stephenfin): There appears to be a bug in Django 1.10.x under
-        # Python 3.5, meaning we can't use 'override_settings' here or we cause
-        # the REST API tests to fail. We should investigate this.
         with self.settings(ENABLE_REST_API=False):
             response = self.client.get(reverse('about'))
             self.assertFalse(response.context['enabled_apis']['rest'])
-- 
2.17.1



More information about the Patchwork mailing list