[PATCH] views: Use select_related, not prefetch_related

Stephen Finucane stephen at that.guru
Wed Oct 31 00:54:24 AEDT 2018


On Wed, 2018-10-31 at 00:47 +1100, Daniel Axtens wrote:
> Daniel Axtens <dja at axtens.net> writes:
> 
> > Stephen Finucane <stephen at that.guru> writes:
> > 
> > > Now that there's a 1:N rather than N:M relationship between series and
> > > patches, we should be using select_related rather than prefetch_related.
> > > 
> > 
> > Tested-by: Daniel Axtens <dja at axtens.net>
> > 
> > And applied, thank you!
> 
> Much to my shame this breaks pep8 and I forgot to check before applying.
> 
> I have applied the following fixup:

Good catch. I need to add pre-push hook for this stuff. Note that the
build is also broken because of the PostgreSQL 11 issue. There's a
patch on the list to fix this.

Stephen



More information about the Patchwork mailing list