[PATCH 0/7] Add support for multiple filters

Daniel Axtens dja at axtens.net
Thu May 10 01:09:57 AEST 2018


Stephen Finucane <stephen at that.guru> writes:

> On Wed, 2018-04-11 at 17:13 +0100, Stephen Finucane wrote:
>> When writing git-pw, it was assumed that one could specify a filter
>> multiple times and it would be applied that way. This turned out to be a
>> false assumption and only the latest filter is applied. This is
>> confusing and prevents a number of possible usecases. Fix this.
>
> Will I respin this or are you happy to address the comments at merge
> time, Daniel?
I can do it at merge this morning. I'll let you know if anything goes
wrong and I need a respin.

Regards,
Daniel

>
> Stephen
>
>> Stephen Finucane (7):
>>   REST: Use UserFilter for patch delegates
>>   REST: Simplify ModelMultiChoiceField
>>   REST: Use ModelMultipleChoiceField
>>   REST: Remove ProjectFilterMixin
>>   REST: Rename Filter -> FilterSet
>>   REST: Use ModelMultipleChoiceField for other fields
>>   REST: Use DRF-specific filterset
>> 
>>  patchwork/api/bundle.py                            |   4 +-
>>  patchwork/api/check.py                             |   4 +-
>>  patchwork/api/cover.py                             |   4 +-
>>  patchwork/api/event.py                             |   4 +-
>>  patchwork/api/filters.py                           | 162 ++++++++++++---------
>>  patchwork/api/patch.py                             |   4 +-
>>  patchwork/api/series.py                            |   4 +-
>>  patchwork/tests/api/test_patch.py                  |  15 +-
>>  .../improved-rest-filtering-bf68399270a9b245.yaml  |  10 +-
>>  9 files changed, 129 insertions(+), 82 deletions(-)
>> 


More information about the Patchwork mailing list