[PATCH 1/7] REST: Use UserFilter for patch delegates
Stephen Finucane
stephen at that.guru
Wed May 9 01:38:17 AEST 2018
On Wed, 2018-05-09 at 01:18 +1000, Daniel Axtens wrote:
> Stephen Finucane <stephen at that.guru> writes:
>
> > Signed-off-by: Stephen Finucane <stephen at that.guru>
> > ---
> > patchwork/api/filters.py | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/patchwork/api/filters.py b/patchwork/api/filters.py
> > index eed7995d..25956e98 100644
> > --- a/patchwork/api/filters.py
> > +++ b/patchwork/api/filters.py
> > @@ -158,8 +158,9 @@ class CoverLetterFilter(ProjectMixin, TimestampMixin, FilterSet):
> >
> > class PatchFilter(ProjectMixin, TimestampMixin, FilterSet):
> >
> > - state = StateFilter(queryset=State.objects.all())
> > submitter = PersonFilter(queryset=Person.objects.all())
> > + delegate = UserFilter(queryset=User.objects.all())
> > + state = StateFilter(queryset=State.objects.all())
>
> Minor nit, is there a reason state is moved?
Yup, it's a stylistic thing (the fields are in the same order that
they're listed in in 'Meta.fields'). You can drop this hunk if you'd
like but it's also no harm.
Stephen
> Happy to fix when applying.
>
> Regards,
> Daniel
>
> >
> > class Meta:
> > model = Patch
> > --
> > 2.14.3
> >
> > _______________________________________________
> > Patchwork mailing list
> > Patchwork at lists.ozlabs.org
> > https://lists.ozlabs.org/listinfo/patchwork
More information about the Patchwork
mailing list